Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Error 500 when creating a promotion with unset dates #90

Open
rachidtt opened this issue Dec 2, 2022 · 0 comments
Open

BUG: Error 500 when creating a promotion with unset dates #90

rachidtt opened this issue Dec 2, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@rachidtt
Copy link
Collaborator

rachidtt commented Dec 2, 2022

Reproduce:
Go to UI fill out all values except start and end (leave default "mm/dd/yyyy")
Press Create
=> Error 500

FIX:
We can either have the backend set default values for bad date inputs (ex: start = today, end=today+1month)
Or we can make the front end check that the dates are set, otherwise Create gives a message but doesn't send the request

Ideally, fix from the backend so that direct api calls (outisde of UI) don't throw the error

@rachidtt rachidtt added the bug Something isn't working label Dec 2, 2022
@JosephSalerno JosephSalerno self-assigned this Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants