Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Highlighting of Files Based on File Extension #122

Open
mikeholler opened this issue Mar 9, 2014 · 5 comments
Open

Syntax Highlighting of Files Based on File Extension #122

mikeholler opened this issue Mar 9, 2014 · 5 comments
Assignees
Milestone

Comments

@mikeholler
Copy link

@xwang12, I know we talked about this before but I think slipped through the cracks. The ACE editor needs to highlight files based on their file extension. Is this going to be something you'll be able to do before the demo on Thursday? We promised that to Demond last demo.

@mikeholler mikeholler added this to the v1.0 milestone Mar 9, 2014
@xwang12
Copy link

xwang12 commented Mar 9, 2014

I will try but I will do the "save file alert when users try to close a tab they have changed " first. I actually ask Prof. St. Clair on Thursday about the highlight thing, she said if it's complex, I don't need to do it. It's not simple, so I will try my best to get it done as soon as possible.

On Mar 8, 2014, at 6:51 PM, "Michael Holler" [email protected] wrote:

@xwang12, I know we talked about this before but I think slipped through the cracks. The ACE editor needs to highlight files based on their file extension. Is this going to be something you'll be able to do before the demo on Thursday? We promised that to Demond last demo.


Reply to this email directly or view it on GitHub.

@mikeholler
Copy link
Author

Okay, thanks! I agree on tab close save prompt is more important than highlighting, so definitely focus on that first. Highlighting would be very nice if you can get to it, but don't feel too pressured.

@xwang12
Copy link

xwang12 commented Mar 9, 2014

Quick question: do we want an alert to remind users save files or an alert to ask users if they want to save their files?
I remembered that we just want a remind alert so just double check. @apotheos

@mikeholler
Copy link
Author

Something like, "This file has changed since you last saved it. Are you
sure you want to close?"
On Mar 8, 2014 8:35 PM, "Xiao Wang" [email protected] wrote:

Quick question: do we want an alert to remind users save files or an alert
to ask users if they want to save their files?
I remembered that we just want a remind alert so just double check.
@apotheos https://github.com/apotheos

Reply to this email directly or view it on GitHubhttps://github.com//issues/122#issuecomment-37117193
.

@ZAM-
Copy link
Contributor

ZAM- commented Mar 14, 2014

I'm curious as to where we are on this feature.

xwang12 pushed a commit to xwang12/TeamworkEnglewoodGit that referenced this issue Mar 21, 2014
mikeholler pushed a commit that referenced this issue Mar 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants