You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make sure the naming of all branches, issues and pull requests follow the naming standard
Make sure all pull requests are linked to an issue by inserting the number after "fixes #" in pull request template. (Remember to do this when you make a pull request!)
Documentation for our code
ReadMe file needs to have more details
Remove all redundant code
Tests for our code
all entities and use cases must have tests
Controllers, presenters, gateways: might be more or less relevant to prioritize testing based on the specifics. For example, if you have defined an input boundary, it is then clear how to test a controller, since you can implement the input boundary as necessary to test the controller in isolation from the use case (of course, this may be worth doing or it might not have any obvious value in terms of demonstrating the correctness of your code).
Outer layers: no need to test
For high marks: additional evidence of things like mention of how you tested your code, discussion of what didn't you test (and why didn't you test it), provided documentation of your test coverage (which could just be generated using IntelliJ)
For those that we choose not to test: demonstrate how you could test it and then leave an Issue in your repo (mainly for outer layers)
For our Milestone 5 submission, we need to make note of everything new from Milestone 4
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Beta Was this translation helpful? Give feedback.
All reactions