Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider b tagging 2017 procedure, and generally handling 2016/2017 differences #58

Open
watson-ij opened this issue May 15, 2018 · 4 comments
Assignees

Comments

@watson-ij
Copy link
Contributor

BTagging in 2017 will use DeepCSV while 2016 uses CSVv2. I would like to keep the repository unified (i.e. don't split off a separate branch for 2017 if we can help it). How can we do this if the structure of the nanoAOD changes?

@jshlee
Copy link
Collaborator

jshlee commented Sep 13, 2018

keep both variables in header??

@watson-ij
Copy link
Contributor Author

We need to add some 2016/17 switch in the code though, no one has worked on 2017 as far as I know, so this is still tbd

@quark2
Copy link
Contributor

quark2 commented Nov 14, 2018

Um, I don't understand the situ. We already have variables for both of CSVv2 and DeepCSV; see https://github.com/CPLUOS/nano/blob/master/analysis/interface/Events_2016v4.h#L190-L193. Is there no CSVv2 in nanoAOD production codes for 2017 (although it might not cause a serious problem, just a unharmful warning and that's all, I think)?

@jshlee
Copy link
Collaborator

jshlee commented Nov 14, 2018

@watson-ij how did you want to handle the difference?
i think in 2017 we will use deep B tags.
we can either have the analysis code tell the difference between 2016 and 2017 or have a loose/medium/tight btag cut which changes for 2016 and 2017 during production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants