Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document external/ directory #55

Open
watson-ij opened this issue May 15, 2018 · 7 comments
Open

Document external/ directory #55

watson-ij opened this issue May 15, 2018 · 7 comments

Comments

@watson-ij
Copy link
Contributor

Can we add a README or wiki page that documents where the code we've taken comes from, and if/what we changed (mostly I think this was just splitting the header and cxx)

@watson-ij
Copy link
Contributor Author

watson-ij commented May 15, 2018

Also, we should document where the procedure we follow for scale factors comes from.

@jshlee
Copy link
Collaborator

jshlee commented May 15, 2018

i prefer adding to wiki (https://github.com/CPLUOS/nano/wiki)

@tt8888tt
Copy link
Collaborator

tt8888tt commented Jun 7, 2018

I guess this issue can be closed? unless there're more things you want it to be added.

@watson-ij
Copy link
Contributor Author

Well, once its documented where the files came from. We have a wiki for data but not yet externals or?

@jshlee
Copy link
Collaborator

jshlee commented Sep 13, 2018

is this finished? can we close?

@watson-ij
Copy link
Contributor Author

watson-ij commented Sep 14, 2018

No one ever updated the wiki with externals information @YeChanKang @DanielLee1004

@quark2
Copy link
Contributor

quark2 commented Nov 21, 2018

First strike on the documentation: See [1]. Only lumiTools and pileupTool has been documented. The remainings will be filled.

[1] https://github.com/CPLUOS/nano/wiki/Usage-of-external-codes#how-to-set-the-numbers-in-this-module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests