Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PU tool has hardcoded 2016 information #51

Open
watson-ij opened this issue May 15, 2018 · 7 comments
Open

PU tool has hardcoded 2016 information #51

watson-ij opened this issue May 15, 2018 · 7 comments
Assignees

Comments

@watson-ij
Copy link
Contributor

This is a left-over from CATTools as I understood it. Where are these numbers from? Is there a nice way to be able to choose based on run conditions.

More generally, we should think how we will run 2016 and 2017 data together when it comes time to do that.

@yeckang
Copy link
Contributor

yeckang commented May 15, 2018

I will add commented lines for where did they come from, and make arguments for year. It doesn't take long time.

@watson-ij
Copy link
Contributor Author

Can you put the origin information also on the wiki?

@yeckang
Copy link
Contributor

yeckang commented May 15, 2018

Yep, sure. I will put as commented lines.

@jshlee
Copy link
Collaborator

jshlee commented Sep 13, 2018

is this finished? can we close?

@watson-ij
Copy link
Contributor Author

no one has done 2017 as far as Im aware.

@jshlee
Copy link
Collaborator

jshlee commented Nov 13, 2018

yebin and dongjun, can u check this and also add in 2017 samples

@quark2
Copy link
Contributor

quark2 commented Nov 21, 2018

I made a description for the origin of the numbers in the tool; see here. I think we can make the table for 2017 in a similar way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants