Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification Index #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add notification Index #47

wants to merge 1 commit into from

Conversation

pavel-ilin
Copy link

⚠️ IMPORTANT: Please do not create a Pull Request without creating an Issue first.

All changes need to be discussed before proceeding. Failure to do so may result in the pull request being rejected.

Before submitting a pull request, please be sure to review:


Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.

Fixes #38

Summary

Add last index to the sendSms function. But having problem doe to lack of experience with Go.

Details

  • add last index value to the subscribe service
  • add LastIndex variable to the sendSMS service
  • in sendNotification point to the lastIndex variable as index to select from notification dataset
  • in Handler function trying to update record in MongoDB, but having a problem: multiple-value phoneNumbersCollection.UpdateOne() in single-value context.
    -- potential solution: create new function which will connect to DB again and update values. I believe that there is a way to do that within Handler function without necessity to repeat connection to DB code, but I'm a bit lost.

Feedback and assistance very much appreciate!

Test Plan (required)

Not ready for testing

Final Checklist

  • For CoronaTracker, did you bump the version in package.json?
    • Update the second decimal for a major change
    • Update the third decimal for a minor change
    • Numbers can go past 9, e.g. 1.0.9 => 1.0.10
    • For more info, read about Semantic Versioning
  • Did you add any new tests as necessary?
  • Is your PR rebased off the most current master?
  • Have you squashed all commits? (can be done at merge)
  • Did you use yarn not npm? (important!)
  • Did you use Material-UI wherever possible?
  • Did you run yarn lint on the code?
  • Did you run all of your most recent changes locally to make sure everything is working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit duplicate notifications sent to phone numbers
1 participant