Fix usage of default #421
Closed
Fix usage of default #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbosch
force-pushed
the
erik_default
branch
from
0fa13fc to
dd1430d
Compare
| f"--output {out} --types {types_file}" | ||
| ) | ||
| env = os.environ.copy() | ||
| env["COLUMNS"] = "200" |
There was a problem hiding this comment.
In general I think we should try to get away from checking stdout output due to the ugliness of the COLUMS thingy.
The good alternative I see is using --log-file and parsing that log file instead. That one does not have terminal width dependant breakpoints.
I have just created a PR that does that for all old tests: #424
There was a problem hiding this comment.
Will look at that one and then I can rebase/refatcor this one afterwards
Signed-off-by: Erik Jaegervall <[email protected]>
Signed-off-by: Erik Jaegervall <[email protected]>
erikbosch
force-pushed
the
erik_default
branch
from
dd1430d to
e54be57
Compare
|
Might be not needed anymore (besides the test). Implemented |
|
To be closed if #425 is merged |
|
Closed as no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from a discussion on using default for structs. As of today we state in https://covesa.github.io/vehicle_signal_specification/rule_set/data_entry/data_types_struct/index.html#default-values that we do not support them, except for one special case.
This PR adds a check that matches that.
Side note: @UlfBj may propose a change to allow default for struct types. If so we will need to refactor the code that checks default to either: