Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tool support for quantities #312

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

erikbosch
Copy link
Collaborator

Take advantage of that VSS standard catalog now contains a quantity file. With this change an information message is given if there is no matching quantity-definition for a unit-definition. For now I opted to use "info" level, we may later raise it to "warning" or possibly even "error" for standard catalog PRs.

Output for standard catalog:

erik@debian4:~/vehicle_signal_specification$ make csv
./vss-tools/vspec2csv.py -I ./spec --uuid -u ./spec/units.yaml ./spec/VehicleSignalSpecification.vspec vss_rel_$(cat VERSION).csv
INFO     Output to csv format
INFO     Known extended attributes: 
INFO     Added 29 quantities from /home/erik/vehicle_signal_specification/spec/quantities.yaml
INFO     Added 60 units from ./spec/units.yaml
INFO     Loading vspec from ./spec/VehicleSignalSpecification.vspec...
INFO     Calling exporter...
INFO     Generating CSV output...
INFO     All done.

Example on message given if quantity is not defined:
(Quantity mazz used by unit lbs has not been defined)

erik@debian4:~/vehicle_signal_specification$ make csv
./vss-tools/vspec2csv.py -I ./spec --uuid -u ./spec/units.yaml ./spec/VehicleSignalSpecification.vspec vss_rel_$(cat VERSION).csv
INFO     Output to csv format
INFO     Known extended attributes: 
INFO     Added 29 quantities from /home/erik/vehicle_signal_specification/spec/quantities.yaml
INFO     Quantity mazz used by unit lbs has not been defined
INFO     Added 60 units from ./spec/units.yaml
INFO     Loading vspec from ./spec/VehicleSignalSpecification.vspec...
INFO     Calling exporter...
INFO     Generating CSV output...
INFO     All done.

Signed-off-by: Erik Jaegervall <[email protected]>
@erikbosch erikbosch marked this pull request as ready for review November 28, 2023 09:09
@erikbosch erikbosch merged commit c96fbbf into COVESA:master Dec 1, 2023
7 checks passed
@erikbosch erikbosch deleted the erik_unit branch December 1, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant