You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For automatically consuming modals data for each language, it's preferred to have a column in the modals.csv file named 'expression'. This column is missing for some languages, for example Japanese and Mandarin. Moreover, the columns that exist in these languages that are candidates to be renamed to 'expression' are not consistently named. Haven't checked how many languages need to be unified.
For example, here are some columns in the modals.csv files for a few languages.
Inconsistent column naming
Flavor vs. flavour
The column should be consistently named. I have a preference for 'flavor'. Haven't checked how many languages vary in this way.
Compare the column names for Greek and Akan:
Greek:
expression,force,flavour,can_express,polarity,syntactically_negated,full_form,notes
Akan:
expression,force,flavor,can_express,polarity,syntactically_negated,full_form,notes
Expression column
For automatically consuming modals data for each language, it's preferred to have a column in the modals.csv file named 'expression'. This column is missing for some languages, for example Japanese and Mandarin. Moreover, the columns that exist in these languages that are candidates to be renamed to 'expression' are not consistently named. Haven't checked how many languages need to be unified.
For example, here are some columns in the modals.csv files for a few languages.
Mandarin:
"""core"" form",force,flavor,can_express,polarity,syntactically_negated,full_form,notes
Japanese:
“core” form,force,flavor,can_express,polarity,syntactically_negated,full_form,notes
I am currently treating values of 'core form' and its variations as values of 'expression'.
If we keep the column 'core form', it should mirror 'full_form', e.g. they should both have underscores or neither should.
The text was updated successfully, but these errors were encountered: