Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent column naming for modals.csv files #29

Open
nathimel opened this issue Feb 12, 2023 · 0 comments
Open

inconsistent column naming for modals.csv files #29

nathimel opened this issue Feb 12, 2023 · 0 comments

Comments

@nathimel
Copy link
Collaborator

Inconsistent column naming

Flavor vs. flavour

The column should be consistently named. I have a preference for 'flavor'. Haven't checked how many languages vary in this way.

Compare the column names for Greek and Akan:

Greek:
expression,force,flavour,can_express,polarity,syntactically_negated,full_form,notes

Akan:
expression,force,flavor,can_express,polarity,syntactically_negated,full_form,notes

Expression column

For automatically consuming modals data for each language, it's preferred to have a column in the modals.csv file named 'expression'. This column is missing for some languages, for example Japanese and Mandarin. Moreover, the columns that exist in these languages that are candidates to be renamed to 'expression' are not consistently named. Haven't checked how many languages need to be unified.

For example, here are some columns in the modals.csv files for a few languages.

Mandarin:
"""core"" form",force,flavor,can_express,polarity,syntactically_negated,full_form,notes

Japanese:
“core” form,force,flavor,can_express,polarity,syntactically_negated,full_form,notes

I am currently treating values of 'core form' and its variations as values of 'expression'.

If we keep the column 'core form', it should mirror 'full_form', e.g. they should both have underscores or neither should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant