c++0x support #51
Comments
|
Oh, this is a dupe of #47 . |
jmhodges
added a commit
to jmhodges/cld2
that referenced
this issue
Oct 23, 2016
Use a bunch of static_cast<uint8> to get around the c++11-narrowing errors when building as C++0x. This hack is necessary because the source files and generation code has not been released. See CLD2Owners#33 on the source file check-in. See CLD2Owners#47 CLD2Owners#51 CLD2Owners#26 and I'm sure there are others for the C++0x problem.
This was referenced Oct 23, 2016
jmhodges
added a commit
to jmhodges/cld2
that referenced
this issue
Oct 23, 2016
hack up generated files to compile as c++0x
Use a bunch of static_cast<uint8> to get around the c++11-narrowing
errors when building as C++0x.
This hack is necessary because the source files and generation code has
not been released.
See CLD2Owners#33 on the source file
check-in.
See CLD2Owners#47
CLD2Owners#51
CLD2Owners#26 and I'm sure there are
others for the C++0x problem.
jjhoughton
pushed a commit
to jjhoughton/cld2
that referenced
this issue
Jul 9, 2022
Use a bunch of static_cast<uint8> to get around the c++11-narrowing errors when building as C++0x. This hack is necessary because the source files and generation code has not been released. See CLD2Owners#33 on the source file check-in. See CLD2Owners#47 CLD2Owners#51 CLD2Owners#26 and I'm sure there are others for the C++0x problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, cld2 fails in c++0x builds with errors like c++11-narrowing. This happens, specifically, by default in bazel builds that include cld2.
It'd be nice to have those cleared up. I'm a little afraid to touch files with "generated" in their name instead of editing their sources. Perhaps, y'all have access to those and can fix up the code?
You can repro the problem with
CFLAGS=std=c++0x ./compile.shand you'll get lots of errors similar tocld_generated_cjk_uni_prop_80.cc:169:9: error: constant expression evaluates to -14 which cannot be narrowed to type 'uint8' (aka 'unsigned char') [-Wc++11-narrowing].If there sources are somewhere I can get to, I could try to take a whack at this.
The text was updated successfully, but these errors were encountered: