Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch modules only work if version_select is configured #131

Open
onyxfish opened this issue May 19, 2019 · 3 comments
Open

Fetch modules only work if version_select is configured #131

onyxfish opened this issue May 19, 2019 · 3 comments

Comments

@onyxfish
Copy link

In order to make a new data loader I had to add this to my YAML config:

- id_name: version_select
  type: custom
  name: Update

This should be in the docs.

@onyxfish onyxfish changed the title Fetch modules only work if version_select is provided Fetch modules only work if version_select is configured May 19, 2019
@onyxfish
Copy link
Author

Related to this, it's also unclear to me what the loads_data: true flag actually does. I was expecting that to enable the versioning, but it doesn't seem to.

@adamhooper
Copy link
Contributor

We are currently working on removing this wart. We're re-evaluating what "versions" actually are (they shouldn't be params); and we plan to eventually nix all "custom" params.

@jstray
Copy link
Collaborator

jstray commented May 20, 2019

Meanwhile, I've added the version_select bit to the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants