Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update opticep test to handle new dsnow optional arguments properly. #998

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Update opticep test to handle new dsnow optional arguments properly. #998

merged 1 commit into from
Nov 16, 2024

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Nov 16, 2024

PR checklist

  • Short (1 sentence) summary of your PR:
    Update opticep test to handle new dsnow optional arguments properly.
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    ran a quick test to confirm fix, will test more as part of prerelease testing.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Update opticep test to handle new dsnow optional arguments properly.

@apcraig apcraig merged commit 3ba4042 into CICE-Consortium:main Nov 16, 2024
2 checks passed
@NickSzapiro-NOAA NickSzapiro-NOAA mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@apcraig