-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PETSc examples refinement #603
Comments
I put a new thing in the sphere mesh that automatically projects to the correct shape when you refine. This says that the closure size is 12, which looks right for a linear quad with 3D coordinates, but the dual space is of size 9, so it looks like it was created for a linear triangle with 3D coordinates. And now I see the error. It is on line 2202 of plexcreate.c. The PETSC_TRUE should be 'simplex'. Do you guys want to fix it or do you want me to make an MR? |
If it's thta simple at the line that you pointed, I can do it. Thanks! |
Go ahead and change it so you can get your thing running, but I made a branch already and added tests :) |
Ok, so if you started a branch with tests, I think it's better if you start
the MR, too. Please link it here when you open it, so I know which one it
is.
Thanks!
…On Sat, Aug 8, 2020, 09:40 Matthew Knepley ***@***.***> wrote:
Go ahead and change it so you can get your thing running, but I made a
branch already and added tests :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#603 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJQVA7WKYVDNALP6VWD4NOLR7VWWJANCNFSM4PYG5SLQ>
.
|
I don't know what's changed on the PETSc side lately, but currently on
main
our problems that use uniform refinement, e.g.,examples/petsc/area
andexamples/petsc/bpssphere
are broken. Our CI didn't catch this because it doesn't test the refinement. It should have. I'm going to add it.I'm investigating this issue, but I don't know exactly what has changed to cause it. It was fine until a few days ago. This also affects PR #550 .
To reproduce:
Stack trace:
The text was updated successfully, but these errors were encountered: