Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Deprecate nextclade_json_paser.py and use VCF files for Mutations Tracking #23

Closed
molly-hetheringtonrauth opened this issue Apr 24, 2024 · 1 comment

Comments

@molly-hetheringtonrauth
Copy link
Contributor

Feature Request

As a group we have decided to deprecate the "nextclade_json_parser.py" script because we can get the same information from vcf files. This has several effects described below.

Solution

  1. Remove the nextclade json parser task from the "lineage_calling_and_results.wdl"
  2. ONT assembly - currently the medaka task outputs a vcf file without AA annotations. We can use SnpEff to annotate the vcf file with AAs. We maybe want to convert the annotated vcf file to a tsv, if possible.
  3. We will want to be able to pull out the S gene mutations from the vcf/tsv file for number 3 below.
  4. "summary.py" - currently, we are pulling the clade, total amino acid substitutions etc. from the"nextclade_results.csv" output from the nextclade json parser and pulling the S gene mutations out of the "nextclade_variants.csv" file output form the nextclade json parser. We can pull the clade, total amino acid substitutions, etc. out of the "nextclade.csv" file output from the nextclade task itself. We will need to decide how best to recreate the s gene mutations column.

Upstream effects

None outside of the lineage_calling_and_results.wdl

Downstream effects

If any column changes in the summary_results output file then this could have implications for BigQuery and the Covid QC notebook.

@danpolanco
Copy link
Contributor

Closing as duplicate of #18.

@danpolanco danpolanco closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants