Add Unit Tests #26
Merged
Add Unit Tests #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
payneBrandon
reviewed
Jul 9, 2024
| } | ||
|
|
||
| @Test | ||
| void testGetEnvironmentVariableEmpty() { |
There was a problem hiding this comment.
Are we testing anything different than the testGetEnvironmentVariableNotSet method above?
There was a problem hiding this comment.
This tests when the environment variable is set to the empty string instead of when it's not set at all as that's the other case when the default variable is used. I've consolidated these two cases into one test.
dmccoystephenson
approved these changes
Jul 11, 2024
pom.xml
Outdated
| @@ -10,6 +10,8 @@ | |||
| <properties> | |||
| <maven.compiler.source>21</maven.compiler.source> | |||
| <maven.compiler.target>21</maven.compiler.target> | |||
| <jmockit.version>1.49</jmockit.version> | |||
| <powermock.version>2.0.2</powermock.version> | |||
There was a problem hiding this comment.
Is this powermock dependency used anywhere?
There was a problem hiding this comment.
It is not - this has been removed
drewjj
approved these changes
Jul 12, 2024
These issues with running tests in VSCode should be fixed now. |
drewjj
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the S3-depositor methods.
Additionally, there is some refactoring within the depositor to allow its methods to be tested.
These changes were tested with Maven and verified to run correctly.