Removed docker CI actions & reduced installation duplication in dockerfiles #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmccoystephenson
pushed a commit
that referenced
this pull request
Oct 8, 2024
Merge Release/2024 q3 into master branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Dan has requested (on usdot-jpo-ode#37) that we remove a couple of docker CI actions & was wondering whether we could copy packages from the builder to the runtime image to avoid duplicating package installation.
Solution
The docker setup & build/push actions have been removed from the
ci.ymlfile.Additionally, the dockerfiles have been modified to first define an image with runtime dependencies, which is used as the base image for the builder & runtime images.
Testing
do_kafka_test.shscript executed successfully.