Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting parameters for changeTimeZone function #16939

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Formatting parameters for changeTimeZone function #16939

wants to merge 5 commits into from

Conversation

lucero-v
Copy link
Collaborator

This PR adds ability to change time zone with additional parameters: timeZoneFormat, convertPositiveDateTimeOffsetToNegative and useHighPrecisionHeaderDateTimeFormat

Test Steps:

  1. run tests in CustomFHIRFunctionsTests and in DateUtilitiesTests

Changes

  • removed hard-coded values for timeZoneFormat, convertPositiveDateTimeOffsetToNegative and useHighPrecisionHeaderDateTimeFormat
  • added error-handling when datetime string can't be parsed
  • added better way to check when input is Date-only
  • added fix for parsing high precision datetime string

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

  • Fixes #issue

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

@lucero-v lucero-v requested a review from a team as a code owner December 31, 2024 23:39
@lucero-v lucero-v self-assigned this Dec 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@lucero-v lucero-v added the onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS. label Dec 31, 2024
@lucero-v lucero-v linked an issue Dec 31, 2024 that may be closed by this pull request
Enable Date Time Format for Receivers in the UP #16910
Open
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited
Loading

Test Results

1 270 tests  +2   1 266 ✅ +2   8m 5s ⏱️ +7s
  164 suites ±0       4 💤 ±0 
  164 files   ±0       0 ❌ ±0 

Results for commit 7f50109. ± Comparison against base commit a46da3b.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025 •
edited
Loading

Integration Test Results

 60 files  ±0   60 suites  ±0   43m 38s ⏱️ -40s
427 tests ±0  417 ✅ ±0  10 💤 ±0  0 ❌ ±0 
430 runs  ±0  420 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit 7f50109. ± Comparison against base commit a46da3b.

♻️ This comment has been updated with latest results.

@lucero-v lucero-v enabled auto-merge (squash) January 2, 2025 23:19
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

oslynn
oslynn reviewed Jan 3, 2025
View reviewed changes
prime-router/src/main/kotlin/fhirengine/translation/hl7/utils/CustomFHIRFunctions.kt
1,
1
4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@oslynn
Copy link
Collaborator

oslynn commented Jan 3, 2025

Thank you for the fix.

@oslynn oslynn mentioned this pull request Jan 3, 2025
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oslynn oslynn oslynn approved these changes

@the-andrew the-andrew Awaiting requested review from the-andrew

@victor-chaparro victor-chaparro Awaiting requested review from victor-chaparro

@abiphilipnava abiphilipnava Awaiting requested review from abiphilipnava

At least 1 approving review is required to merge this pull request.

Assignees

@lucero-v lucero-v

Labels
onboarding-ops Work related to onboarding with a partner. Addressed by the Onboarding & Operations team in RS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Date Time Format for Receivers in the UP
2 participants
@lucero-v @oslynn