Merge pull request #4 from machadoum/fix-ci

Remove traces of asset criticality settings from cypress tests
CAWilson94 · Oct 15, 2024 · 4f6e89a · 4f6e89a
2 parents 2af61d4 + 03cf272
commit 4f6e89a
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 9 deletions.
diff --git a/...ecurity_solution_cypress/cypress/e2e/entity_analytics/asset_criticality_upload_page.cy.ts b/...ecurity_solution_cypress/cypress/e2e/entity_analytics/asset_criticality_upload_page.cy.ts
@@ -12,7 +12,6 @@ import {
   RESULT_STEP,
   VALID_LINES_MESSAGE,
 } from '../../screens/asset_criticality';
-import { enableAssetCriticality } from '../../tasks/api_calls/kibana_advanced_settings';
 import { clickAssignButton, uploadAssetCriticalityFile } from '../../tasks/asset_criticality';
 import { login } from '../../tasks/login';
 import { visit } from '../../tasks/navigation';
@@ -26,7 +25,6 @@ describe(
   () => {
     beforeEach(() => {
       login();
-      enableAssetCriticality();
       visit(ENTITY_ANALYTICS_ASSET_CRITICALITY_URL);
     });
 

diff --git a/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_flyout.cy.ts b/x-pack/test/security_solution_cypress/cypress/e2e/entity_analytics/entity_flyout.cy.ts
@@ -42,7 +42,6 @@ import {
   ENTRA_DOCUMENT_TAB,
   OKTA_DOCUMENT_TAB,
 } from '../../screens/users/flyout_asset_panel';
-import { enableAssetCriticality } from '../../tasks/api_calls/kibana_advanced_settings';
 
 const USER_NAME = 'user1';
 const SIEM_KIBANA_HOST_NAME = 'Host-fwarau82er';
@@ -66,7 +65,6 @@ describe(
       cy.task('esArchiverLoad', { archiveName: 'risk_scores_new_complete_data' });
       cy.task('esArchiverLoad', { archiveName: 'query_alert', useCreate: true, docsOnly: true });
       cy.task('esArchiverLoad', { archiveName: 'user_managed_data' });
-      enableAssetCriticality();
       mockRiskEngineEnabled();
       login();
       visitWithTimeRange(ALERTS_URL);

diff --git a/x-pack/test/security_solution_cypress/cypress/tasks/api_calls/kibana_advanced_settings.ts b/x-pack/test/security_solution_cypress/cypress/tasks/api_calls/kibana_advanced_settings.ts
@@ -6,7 +6,6 @@
  */
 
 import { SECURITY_SOLUTION_SHOW_RELATED_INTEGRATIONS_ID } from '@kbn/management-settings-ids';
-import { ENABLE_ASSET_CRITICALITY_SETTING } from '@kbn/security-solution-plugin/common/constants';
 import { rootRequest } from './common';
 
 export const setKibanaSetting = (key: string, value: boolean | number | string) => {
@@ -24,7 +23,3 @@ export const enableRelatedIntegrations = () => {
 export const disableRelatedIntegrations = () => {
   setKibanaSetting(SECURITY_SOLUTION_SHOW_RELATED_INTEGRATIONS_ID, false);
 };
-
-export const enableAssetCriticality = () => {
-  setKibanaSetting(ENABLE_ASSET_CRITICALITY_SETTING, true);
-};