Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code and design refctore #69

Open
husamkamal opened this issue Oct 21, 2022 · 3 comments
Open

code and design refctore #69

husamkamal opened this issue Oct 21, 2022 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@husamkamal
Copy link
Collaborator

husamkamal commented Oct 21, 2022

some refactor :

Screenshot from 2022-10-21 22-07-39
space between brands and the background of the hero section

Screenshot from 2022-10-21 22-11-37
the border reduis top left and bottom right I think it will be zero

code
remove the interface to interface file from carCard components

code1
make a style file and add remove all styles to the styles file in carCard

  • I think we can make some reactor in carFilter components but I don't know what I can do so you can think about it and discuss it on Sunday

code12
add a component to typography

  • and in sendRequestModel can make code best than the current code and we have some errors we send the mileage but don't send the mileage type it is km or mile and make some changes in the database because we save the number in the database we will discuss this point
@tariqabusada
Copy link
Collaborator

Good notes @husamkamal ,

  • Regarding the mileage, we only deal with the kilometer unit when storing and displaying vehicle information, so I suggest that we check the 'type' variable on the client side, where the site converts the mileage value in case the type is 'mile' then we send the data to the server.

@tariqabusada
Copy link
Collaborator

  • And I want to point out an important thing on the filter page, The model options should be dynamic according to the brand, as the user does not want to search in the models of a brand that he didn't choose, so I suggest that the options value ​​be based on the result of the brand filtering process not on fixed values ​​stored in an array.

@LinaYahya
Copy link
Contributor

LinaYahya commented Oct 23, 2022

  • We need to render react stripe form inside of mui Box
  • cars models need to be connected to brand
  • slider maybe need changes
  • react stripe form (functionality and style)

@LinaYahya LinaYahya added bug Something isn't working enhancement New feature or request labels Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants