Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review -User Interface #38

Open
salsabeelomar opened this issue Jul 28, 2022 · 0 comments
Open

Code Review -User Interface #38

salsabeelomar opened this issue Jul 28, 2022 · 0 comments

Comments

@salsabeelomar
Copy link

Delete product function

When u make it by filter and replace the local storage items with the returned value it’s more efficient

In dom js :

  • The best practice use createElement when u need to create an HTML element the backtick is consuming
  • client btn in index.html doesn't work we need to add functionality to it's click event
  • We should link pages using anchor tags instead of buttons. -
    using buttons need unnecessary javascript to navigate to the required page.
    The buttons in the shopping cart don't work.
  • Add to cart button in the products box grid doesn't store products in the local storage
  • when u need tho make the input type in Number in price
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant