Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global image representations #31

Open
TerryMelody opened this issue Mar 19, 2024 · 4 comments
Open

global image representations #31

TerryMelody opened this issue Mar 19, 2024 · 4 comments

Comments

@TerryMelody
Copy link

Hello dear authors!In the code "image_features, patch_tokens = model.encode_image(image, features_list)", is "image_features" the global image representations? Just like the source code in openclip: "image_features = model.encode_image(image)", as we always do. But you change the transformer to add additional outputs of assigned "features_list". I don't know whether my understanding is right or not.

@ByChelsea
Copy link
Owner

Yes, image_features is the global image representation.

By the way, you can use "copy permalink" to help others locate your issue more quickly. Like this.
image

@TerryMelody
Copy link
Author

Copy link
Thank you for your suggestions! Can I understand the “image features” in your code to be the same as those implemented in Openclip source codes. It seems you make a lot of modifications to openclip (https://github.com/mlfoundations/open_clip/tree/main/src/open_clip)?

@ByChelsea
Copy link
Owner

Yes, image features are the class tokens in the original implementation.

@TerryMelody
Copy link
Author

Yes, image features are the class tokens in the original implementation.

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants