Only build debug representations of arguments on failing tests #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidrusu
changed the title
|
@BurntSushi this change nets us a 50% reduction in quickcheck's overhead It's a fairly small change, so hopefully quick to review. I'd love to see it merged in soon. |
|
There are bug-fixes pending for months. I wouldn't get my hopes up. |
|
+1 for getting this merged asap. else I'll need to start referencing @davidrusu's fork in our crates instead. |
|
+1 is there anyone who wants to maintain this crate, probably we ask @BurntSushi to give rights or just use some other fork, @davidrusu's for instance, to continue developing this. The same is with crates.io, we could just create another crate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #303
This cuts my prop test run-times nearly in half!
Here's the new flamegraph showing nearly 70% of time spent in test, previously this was 40%.
compare to prior run: