-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gen from seed #277
Gen from seed #277
Comments
That seems sensible to me. I think we should leave off the size parameter perhaps though. I regret that Gen's constructor has it instead of providing a |
Can I help by creating a PR? |
Sure! I am on parental leave though, so it could be a while. I rarely get
the chance to open a laptop. :)
…On Mon, Feb 8, 2021, 18:50 Jakob Schikowski ***@***.***> wrote:
Can I help by creating a PR?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#277 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADPPYSQUST7Q22MDRBGTZLS6B2DPANCNFSM4XJ6DBXQ>
.
|
I'm in no hurry, I'll do it within the next days. |
The seed still can't be set by QuickCheck users, but the new Gen constructor is useful for other crates that use QuickCheck only for its Arbitrary trait. Closes BurntSushi#277
May I suggest Gen {
rng: SmallRng::from_rng(rng).unwrap(),
size: 42,
} but got
Maybe just making both fields |
No. Because that makes |
@ggreif |
Great, a |
The seed still can't be set by QuickCheck users, but the new Gen constructor is useful for other crates that use QuickCheck only for its Arbitrary trait. Closes BurntSushi#277
Many crates implement
quickcheck::Arbitrary
and I was very happy that I could use these implementations in dicetest by implementingquickcheck::Gen
. Unfortunately I can't do this anymore since quickcheck 1.0.Would it be possible to provide a function that creates a
Gen
from a seed? Something like that:The text was updated successfully, but these errors were encountered: