-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mut bindings in function arguments #269
Comments
Could you please provide a complete program? Mut bindings should have no impact on quickcheck. |
(Edited my example -- I just meant the mut binding for the function argument, plus the workaround for it.) |
It's here: https://github.com/10XGenomics/rust-boomphf/blob/master/src/lib.rs#L802 (Was looking at it because it started failing after upgrading from 0.9 to 0.10, 10XGenomics/rust-boomphf#19.) |
Okay, so you're talking about the macro. That wasn't at all clear. And you're also reporting this as a regression? I don't think there were any changes to the macro. I don't know when I'll be able to look into this, sorry. The quickcheck macro is not something that I understand well. A minimal reproduction would help. |
I'm not reporting this as a regression -- the breakage is unrelated to this bug report. |
I think the problem is basically in https://github.com/BurntSushi/quickcheck/blob/master/src/lib.rs#L48. The macro takes |
Okay, I'll mark this as an enhancement. My recollection is that the macro is quite gnarly, so anyone who likes playing in macro_rulea muck is invited to take a look at this. :) |
I noticed that this works:
but this doesn't:
Error:
The text was updated successfully, but these errors were encountered: