Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Arbitrary for [T: Arbitrary; N] #187

Open
boustrophedon opened this issue Nov 3, 2017 · 1 comment · May be fixed by #311
Open

Implement Arbitrary for [T: Arbitrary; N] #187

boustrophedon opened this issue Nov 3, 2017 · 1 comment · May be fixed by #311

Comments

@boustrophedon
Copy link

boustrophedon commented Nov 3, 2017

Obviously we can't do full generic N until const generics are implemented. I only wanted it for 3 [f32; 2]s anyway (and settled for six f32s in my function's parameters) and I'd be happy to send a pull request for just [T: Arbitrary; k] for a few small ks if that's good with you.

@BurntSushi
Copy link
Owner

I think historically I've decided to not include these impls because of the compile time hit, with the hope that we could some day provide them with const generics.

I'm not convinced of this position btw. I suppose anyone that tries this should compare compile times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants