Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Make the code extensible and usable outside DepthScene by refactor #43

Open
Tremeschin opened this issue Sep 29, 2024 · 1 comment

Comments

@Tremeschin
Copy link
Member

The readme of ShaderFlow contains a modified DepthFlow shader with a Music Visualizer glued on top and it looks amazing.

The DepthFlow shader can be refactored into a standalone file defining a struct of parameters, and a single function to do the projections (might need to accept a Camera element as well), returning the final coordinate and other utils of the algorithm.

This would allow creating awesome derivative work out of it, instead of doing everything inside its own void main() function on GLSL !

@Tremeschin Tremeschin moved this to Working in Tasks Sep 29, 2024
@Tremeschin Tremeschin added this to Tasks Sep 29, 2024
@Tremeschin Tremeschin removed the status in Tasks Sep 29, 2024
@Tremeschin Tremeschin moved this to Todo in Tasks Sep 29, 2024
@Tremeschin
Copy link
Member Author

I've pulled off a shader rewrite into a DepthFlow struct so this is sorted out, the idea now is to either create a DepthModule inside shaderflow, but that would need an overhaul on the metaprogramming, at least splitting the current shader code before the main makes it usable outside..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

No branches or pull requests

1 participant