Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database Config File #29

Open
rugulous opened this issue Mar 14, 2022 · 1 comment
Open

Database Config File #29

rugulous opened this issue Mar 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@rugulous
Copy link
Member

Is your feature request related to a problem? Please describe.
There needs to be a way to allow us to pass in DB connection details

Describe the solution you'd like
We should add a new config file with the following values:

  • host
  • user
  • password
  • database
  • waitForConnections
  • connectionLimit

Additional context
Using a config file means we don't have to hardcode values anywhere, making it easier to change inbetween installations
@rugulous rugulous added the enhancement New feature or request label Mar 14, 2022
@rugulous rugulous mentioned this issue Mar 18, 2022
Merged
@rugulous
Copy link
Member Author

Now we're using sequelize we need to take those changes into account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rugulous