-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validation/Form Style #14
Comments
I personally prefer option 1 as it's the more "traditional" way things are done; equally, having the action button disabled to start with could confuse people as they may not realise they need to fill fields in to enable it. @matt-fidd @laurenacton what do you guys think? |
with the first one i assume the pop up would also come up? like saying "please fill in the email" or whatever. if so then yeah id say the first one, we'd just need to figure out where the pop up would be going because you don't want it covering the stuff that they haven't filled in right. |
@laurenacton - sorry, not the best example for 2. The popup isn't part of what I meant for this... What I meant was, the form starts like this Then, once the fields are filled in, it's only once all the fields are valid that the "Sign In" button becomes clickable? Additionally, if there are any errors with the fields they would be highlighted as soon as you move off it (if that makes sense?) |
Personally not a fan of number 2, I don't think it looks as nice and number 1 has the same functionality whilst keeping the page neater. I think the largely adopted approach recently is to have on-the-fly validation attached to an onBlur event for the input boxes. I think this is what you were talking about here...
Additionally, it is preferred from an accessibility and ease of use standpoint to have the |
We need to decide on our approach for forms and their validation.
There are two main approaches that I see:
The text was updated successfully, but these errors were encountered: