Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in importing of subComponents of Modal #100

Open
manojmalik20 opened this issue Oct 12, 2023 · 0 comments
Open

Error in importing of subComponents of Modal #100

manojmalik20 opened this issue Oct 12, 2023 · 0 comments
Assignees

Comments

@manojmalik20
Copy link
Contributor

manojmalik20 commented Oct 12, 2023

Summary

There's an issue in the importing of subComponents types in the file src/components/Modal/Modal.d.ts. The imports work fine in the mm-ui-library but after building, when we use the component inside a plugin, the imports of ModalFooterProps and ModalHeaderProps are not resolving, due to which we are not able to use the props inside them like title, subtitle etc.

Version / Branch

The branch this is reproduced on is downgrade-bootstrap-epic.

Links

import {ModalFooterProps} from './subComponents/ModalFooter/ModalFooter';

Errors

Type '{ children: Element; show: boolean; onCloseHandler: () => void; onSubmitHandler: () => void; title: string; subtitle: string; className: string; primaryActionText: string; secondaryActionText: string; isPrimaryButtonDisabled: boolean; }' is not assignable to type 'IntrinsicAttributes & ModalProps'.
  Property 'title' does not exist on type 'IntrinsicAttributes & ModalProps'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants