New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make webrtc dependencies optional #7

Open

BrettRD opened this issue Jan 13, 2021 · 1 comment

Labels

bug

Owner

BrettRD commented Jan 13, 2021

Most applications don't need WebRTC
webrtc deps should only be imported in pipeline.py when a webrtc bin is loaded

Similar applies to src bins to webrtc, the audio and video bins in and out are not strictly necessary in a given stream.

BrettRD added the enhancement label

BrettRD added bug and removed enhancement labels

Owner Author

BrettRD commented Oct 7, 2021 •

edited

Loading

This actually causes the pipeline node to fail on automated build tools because rosdep does not capture the dependencies.

BrettRD mentioned this issue

Make webrtc dependencies conditional on launch config #34

Merged

samuparta mentioned this issue

Pipeline crashes on close #59

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment