Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rostextsrc buffer duration needs to be set by message contents #22

Open
BrettRD opened this issue Jun 2, 2021 · 2 comments
Open

rostextsrc buffer duration needs to be set by message contents #22

BrettRD opened this issue Jun 2, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@BrettRD
Copy link
Owner

BrettRD commented Jun 2, 2021

The gstreamer textoverlay plugin requires buffer duration flags be set to strictly correct values and freezes the video if buffer duration is set to 0, GST_CLOCK_TIME_NONE, or if the duration expires.

To support textoverlay, rostextsrc should allow the user to configure the buffer timestamps and duration on a per-message basis.

@BrettRD BrettRD changed the title rostextsrc buffer duration rostextsrc buffer duration needs to be set by message contents Jun 2, 2021
@BrettRD
Copy link
Owner Author

BrettRD commented Jun 2, 2021

A temporary workaround for textoverlay uses textrender and compositor

gst-launch-1.0 --gst-plugin-path=install/gst_bridge/lib/gst_bridge/ videotestsrc ! video/x-raw,width=640,height=480 ! mix. rostextsrc ! textrender ! video/x-raw,width=640,height=480 ! compositor name=mix ! videoconvert ! autovideosink

compositor has a z-order property on each pad, this pipeline exploits the default order to place the text in front. The image sources do not need to be the same size or shape; the position and z-order can be set explicitly for multiple sources, see compositor for details
textrender seems to ignore empty strings, but will happily produce a frame containing only whitespace.

@BrettRD BrettRD added the good first issue Good for newcomers label Sep 23, 2021
@BrettRD
Copy link
Owner Author

BrettRD commented Sep 23, 2021

Adding 'good first issue'
If you have an idea and a use-case for a ros message carrying subtitle timing info or similar, I want to hear it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant