Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra data columns to HIFLD grid CSVs beyond those required by PowerSimData #242

Closed
1 task
danielolsen opened this issue Nov 30, 2021 · 2 comments
Closed
1 task
Assignees
Labels
feature request Request for a new feature. (Only lives in Backlog) hifld Related to ingestion of the HIFLD data

Comments

@danielolsen
Copy link
Contributor

danielolsen commented Nov 30, 2021

🚀

  • Is your feature request essential for your project?

Describe the workflow you want to enable

Add extra data columns to HIFLD grid CSVs beyond those required by PowerSimData.

Describe your proposed implementation

The change can be as simple as expanding the list of columns that are written via the top-level orchestration function, or not filtering the columns at all.

Additional context

The corresponding PowerSimData issue to be able to properly interpret CSVs with extra columns is Breakthrough-Energy/PowerSimData#567.

@danielolsen
Copy link
Contributor Author

danielolsen commented Dec 14, 2021

Adding extra data columns also helps with issues like #227, since:

  1. We can generate better solar and wind profiles if we can associate our plant table entries with the richer EIA unit information that's available for solar and wind plants within Form 860. Table 3.1 is generator data for all generators, Table 3.2 is additional wind-specific data, and Table 3.3 is additional solar-specific data.
  2. Without adding extra columns, the only way (?) to be able to look up the corresponding entries after the grid is made is to encode both the Plant Code (int) and the Generator ID (str) as the plant table index, but
  3. PowerSimData expects that the plant table index is integers, to be able to create new indices when adding generators, storage units, etc.

EDIT: now that I think about this a bit more, I think we can get the best of both worlds if we use the full data tables created during Grid CSV creation as inputs to the profile creation, before we filter out all non-PowerSimData columns.

@danielolsen
Copy link
Contributor Author

I think this is effectively achieved via #256, since the create_grid function now returns tables with all columns, and optionally writes just the ones required for PowerSimData, so I think we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature. (Only lives in Backlog) hifld Related to ingestion of the HIFLD data
Projects
None yet
Development

No branches or pull requests

2 participants