Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement internal timeout for invoice payments #609

Open
maybeast opened this issue Jul 12, 2024 · 1 comment
Open

Implement internal timeout for invoice payments #609

maybeast opened this issue Jul 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@maybeast
Copy link
Member

Current Situation

When we're unable to process an invoice payment for 10 minutes, we reset LND's mission control. This reduces the node's routing efficiency and is not ideal, especially if it continues for hours.

Proposed Solution

Introduce a configurable internal timeout (X) that would allow the system to either:

  1. Attempt the payment using another available node, or
  2. Mark the swap as invoice.failedToPay

Benefits

  1. Improved node efficiency: Prevents prolonged periods of reduced routing efficiency caused by frequent mission control resets.
  2. Enhanced user experience: Invoices that cannot be paid will fail faster, resulting in quicker refunds for users.
@maybeast maybeast added the enhancement New feature or request label Jul 12, 2024
@kilrau
Copy link
Member

kilrau commented Jul 16, 2024

Good stuff, how about limiting resetmcs to e.g. 3 per swap for now for faster failing? As currently CLN is still not available for paying invoices...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants