Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTLCs are held too long with prepayminerfee #278

Open
ecdsa opened this issue Apr 1, 2022 · 0 comments
Open

HTLCs are held too long with prepayminerfee #278

ecdsa opened this issue Apr 1, 2022 · 0 comments
Labels
enhancement New feature or request P2

Comments

@ecdsa
Copy link

ecdsa commented Apr 1, 2022

In a reverse swap with prepayminerfee set, two invoices are created, for the payment and for the mining fee.

It is very common that one of the payments finds a route (in general the smaller one, for the mining fee), but the other one fails.
If that happens, the HTLCs of the failing payment are failed quickly, but the HTLCs of the other payment are held for a very long time, until the invoice times out (24 hours, I guess).

The HTLCs of both invoices should be considered as the same payment, and the behaviour should be similar to MPP. If the server does not receive all HTLCs within a reasonable time (similar to the timeout of a MPP), then it should fail the HTLCs it has received so far, and it should also fail those that are received after the timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2
Projects
None yet
Development

No branches or pull requests

2 participants