Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-190] Update go version in go.mod to use 1.N.P format #191

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

jameskim0987
Copy link
Contributor

Resolves #190

Changes made in this PR:

  1. Update go version in go.mod from 1.21 to 1.21.0
  2. Run go mod tidy

@jameskim0987 jameskim0987 marked this pull request as ready for review October 23, 2024 22:56
@jameskim0987
Copy link
Contributor Author

Hi @kehoecj, this PR is ready for review.

I have a question regarding the go version -- since the repo has been using 1.21 already, it has been automatically been using the latest patch of 1.21.x. Come to think of it, is it necessary to specify the patch version at this point in time? If so, what would be the target version be?

@kehoecj kehoecj added hacktoberfest-accepted Valid PR Hacktoberfest PR hacktoberfest 🎃 Hacktoberfest 2024 labels Oct 24, 2024
@kehoecj
Copy link
Collaborator

kehoecj commented Oct 24, 2024

Hi @kehoecj, this PR is ready for review.

I have a question regarding the go version -- since the repo has been using 1.21 already, it has been automatically been using the latest patch of 1.21.x. Come to think of it, is it necessary to specify the patch version at this point in time? If so, what would be the target version be?

I definitely found the documentation a bit confusing as well. This module version just sets a minimal version starting in 1.21 go wants the patch specified as well. So specifying go 1.21.0 just means you need to have at least go 1.21 installed to be able to build. There is some additional consideration if your project is used as a library but the validator is not used in this way. I checked a lot of popular go projects on Github and your solution is consistent with their approach.

@kehoecj kehoecj self-requested a review October 24, 2024 15:03
Copy link
Collaborator

@kehoecj kehoecj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thannks @jameskim0987 !

@kehoecj kehoecj merged commit f5082b4 into Boeing:main Oct 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest 🎃 Hacktoberfest 2024 hacktoberfest-accepted Valid PR Hacktoberfest PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update go version in go.mod to use 1.N.P format
2 participants