EditorConfig file type #145 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
approved these changes
Jul 14, 2024
|
Fixes #145 For records, mentioning issue in title does nothing |
|
Thanks @HakanVardarr |
Oh didn't know that thanks |
kehoecj
added
the
waiting-on-maintainer-review
kehoecj
reviewed
Aug 3, 2024
kehoecj
approved these changes
Aug 3, 2024
It uses the ini library. We have an open issue to that repo to support line and characters in the error message. #27 |
kehoecj
added
OSS Community Contribution
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Aug 23, 2024
* EditorConfig file type * Removed deprecated ParseBytes function * Update pkg/filetype/file_type.go --------- Co-authored-by: Clayton Kehoe <[email protected]>
shiina4119
pushed a commit
to shiina4119/config-file-validator
that referenced
this pull request
Oct 4, 2024
* EditorConfig file type * Removed deprecated ParseBytes function * Update pkg/filetype/file_type.go --------- Co-authored-by: Clayton Kehoe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added EditorConfigValidator and 2 test to the project. Does not log errors very well, I tried to do it the way the library supports