Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ini files #4

Closed
kehoecj opened this issue Apr 28, 2023 · 6 comments
Closed

Add support for ini files #4

kehoecj opened this issue Apr 28, 2023 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed new validation type New config file type to validate

Comments

@kehoecj
Copy link
Collaborator

kehoecj commented Apr 28, 2023 •
edited
Loading

Description

Add support for .ini files. INI files are frequently used on the windows platform as well as ansible and other python tools . Use the go-ini library for the validator.
@kehoecj kehoecj added enhancement New feature or request new validation type New config file type to validate help wanted Extra attention is needed labels Apr 28, 2023
@g41797
Copy link
Contributor

g41797 commented May 11, 2023

i can take it early June

@kehoecj
Copy link
Collaborator Author

kehoecj commented May 11, 2023

@g41797 That'd be great, thanks!

@g41797
Copy link
Contributor

g41797 commented May 19, 2023

go-ini has set of options for different formats of ini files : LoadOptions
Two possibilities:

  • set default values for expected ini format
  • add configurator for file type or at least optional map[string]string

Let's discuss

@kehoecj
Copy link
Collaborator Author

kehoecj commented May 22, 2023

go-ini has set of options for different formats of ini files : LoadOptions Two possibilities:

* set default values for expected ini format

* add configurator for file type or at least optional map[string]string

Let's discuss

I'd vote for using calling the main Load function with the default values for the initial implementation.

@g41797 g41797 mentioned this issue May 25, 2023
Merged
@g41797
Copy link
Contributor

g41797 commented May 25, 2023

Draft PR #25 was created
Please review

@g41797
Copy link
Contributor

g41797 commented May 26, 2023

i'll try to dive deeper

@kehoecj kehoecj closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed new validation type New config file type to validate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@g41797 @kehoecj