Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive CAL_nsamp slows down entire projection #84

Open
quang-huynh opened this issue Sep 1, 2023 · 1 comment
Open

Massive CAL_nsamp slows down entire projection #84

quang-huynh opened this issue Sep 1, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@quang-huynh
Copy link
Member

I have an OM with massive CAL_nsamp = 25000 which I had believed was purely for cosmetic reasons, but it turns out to massively slow down the projections (100 MOM simulations) because MSEtool:::getfifth will generate a 25,000 length vector to calculate the 5 percentile of the length comp.

The easiest solution is to avoid giant nsamp in the first place, but alternative solutions for getfifth could be sought to get around it. The density function appears to be most robust in the edge cases (compared to approx) but is also dependent on sample size

@quang-huynh quang-huynh added the enhancement New feature or request label Sep 1, 2023
@quang-huynh
Copy link
Member Author

Robust code for getfifth is moderately urgent because AddRealData updates CAL_nsamp. Obviously, someone can condition an OM by passing in a length comp matrix with massive numbers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant