Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed jets #212

Open
uncomputable opened this issue Jan 3, 2024 · 4 comments
Open

Renamed jets #212

uncomputable opened this issue Jan 3, 2024 · 4 comments

Comments

@uncomputable
Copy link
Collaborator

The tech report and wiki include the following jets (in front of arrow), but the code base renamed them (after arrow).

  • tap-leaf-hash → tapleaf-hash
  • tapbranch → tappath
  • tapbranch-hash → tappath-hash
  • input-asset-amounts-hash → input-amounts-hash
    • issuance-asset-amounts-hash was not renamed
  • output-asset-amounts-hash -> output-amounts-hash

There may be more inconsistencies related to tap paths and asset amounts.

@roconnor-blockstream
Copy link
Collaborator

The Tech Report seems fine to me.

@uncomputable
Copy link
Collaborator Author

I was using a tech report from one year ago; oops.

Most of the jet names have been fixed. However, it's still tap-leaf-hash in the tech report and tapleaf_hash in the code.

issuance-asset-amounts-hash probably includes asset to differentiate it from issuance-token-amounts-hash. In that case, the longer name makes sense.

@roconnor-blockstream
Copy link
Collaborator

Additionally bip0340-schnorr-verify is written in the tech report; however the code uses bip_0340_verify

@roconnor-blockstream
Copy link
Collaborator

And check-sig-verify is missing from the tech report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants