Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP halfagg TODOs #11

Open
1 of 5 tasks
jonasnick opened this issue Sep 10, 2023 · 3 comments
Open
1 of 5 tasks

BIP halfagg TODOs #11

jonasnick opened this issue Sep 10, 2023 · 3 comments

Comments

@jonasnick
Copy link
Contributor

jonasnick commented Sep 10, 2023

  • Consider setting z_0 = 1 (actually this is the variant that is proposed in Chen & Zhao)
  • Reconsider maximum number of signatures
  • Add failing verification test vectors that exercise edge cases.
  • Add aggregation test vectors (passing and failing, including edge cases)
  • Test latest version of hacspec (run through checker)
@real-or-random
Copy link
Collaborator

real-or-random commented Jan 4, 2024

  • Should we allow the "empty" aggsig (n=0)? -- Yes.

@jonasnick
Copy link
Contributor Author

Should we allow the "empty" aggsig (n=0)?

verify_aggregate currently returns true for an "empty" aggsig (s = 0). I think that makes sense.

@fjahr
Copy link
Contributor

fjahr commented Jul 19, 2024

Can you elaborate on "Reconsider maximum number of signatures"? I assume this refers to this part in the BIP:

The maximum number of signatures that can be aggregated is 2<sub>16</sub> - 1. Having a maximum value is supposed to prevent integer overflows. This specific value was a conservative choice and may be raised in the future (TODO)

So would the goal of this would be to evaluate if it's feasible to raise this number now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants