Typehints for python grpc-methods #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added typehints using the mypy-protobuf package. This requries that `mypy-protobuf` python package is installed. I created a `requirements-dev.txt`-file and added it to the docker-container. The bindings can now be regenerated as follows. Do `make docker-shell`. Inside the newly opened shell you can enter ``` make libs/gl-client-py/Makefile pygrpc ``` and ``` make libs/gl-testing/Makefile testgrpc ```
ErikDeSmedt
force-pushed
the
2023_08_17/python_typehints_using_mypy
branch
from
01ae338 to
dfdf626
Compare
ErikDeSmedt
changed the title
cdecker
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added typehints using the mypy-protobuf package.
This requries that
mypy-protobufpython package is installed.I created a
requirements-dev.txt-file and added it to the docker-container. The bindings can now be regenerated as follows.Do
make docker-shell.Inside the newly opened shell you can enter
and