Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address hardcoded chainfee rate cap of 25000 sat/kw #538

Open
JssDWt opened this issue Nov 1, 2024 · 0 comments
Open

address hardcoded chainfee rate cap of 25000 sat/kw #538

JssDWt opened this issue Nov 1, 2024 · 0 comments

Comments

@JssDWt
Copy link
Collaborator

JssDWt commented Nov 1, 2024

In a VLS policy, there's a hard fee rate cap of 25000 sat/kw. Feerate spikes currently make the greenlight client unusable. Especially if longer periods of high onchain fee rates will come back, having a hardcoded chainfee limit inside the client will break all clients. Since clients will usually have a slow upgrade path, this situation is undesirable.

It makes sense to have some limit inside the signer, to ensure it is not signing anything undesirable. But if chainfees are high, there's not much you can do about that, and signing would be the right thing to do.

Some options:

  • Inject a fee rate source (like mempool.space) in VLS, so it can validate the chainfee rate is sane
  • Ignore fee rates when the chain fee will be paid by the remote peer
  • Remove the hard cap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants