Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy pastes of past files into this new rebase #44

Closed
wants to merge 1 commit into from

Conversation

JosefAlbers
Copy link
Contributor

  • precommit tests (black, isort) run and done.
  • test_models run and done.
  • test run of "python -m mlx_vlm.generate --model microsoft/Phi-3-vision-128k-instruct --max-tokens 100" ok

Fingers crossed🤞🏾

@Blaizzy
Copy link
Owner

Blaizzy commented Jun 23, 2024

You didn't need to create a new branch :)
It could be done on the original PR.

@Blaizzy
Copy link
Owner

Blaizzy commented Jun 23, 2024

The tests styling tests failed

Please run precommit.

pre-commit run --all-files

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted mlx_vlm/tests/test_models.py
reformatted mlx_vlm/utils.py

All done! ✨ 🍰 ✨
2 files reformatted, 41 files left unchanged.

isort....................................................................Failed
- hook id: isort
- files were modified by this hook

Fixing /Users/runner/work/mlx-vlm/mlx-vlm/mlx_vlm/models/phi3_v/language.py
Fixing /Users/runner/work/mlx-vlm/mlx-vlm/mlx_vlm/models/phi3_v/phi3_v.py
Fixing /Users/runner/work/mlx-vlm/mlx-vlm/mlx_vlm/models/phi3_v/su_rope.py
Fixing /Users/runner/work/mlx-vlm/mlx-vlm/mlx_vlm/models/phi3_v/vision.py

Error: Process completed with exit code 1.

@Blaizzy Blaizzy closed this Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants