Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate library from coroutines to async await syntax #67

Open
cooncesean opened this issue Mar 19, 2020 · 0 comments
Open

Migrate library from coroutines to async await syntax #67

cooncesean opened this issue Mar 19, 2020 · 0 comments
Labels
3 code-challenge This issue has been groomed and is ready to be picked up by a code challenge participant.

Comments

@cooncesean
Copy link
Contributor

Context

This library would benefit from upgrading the older style of async code (currently coroutines) to the more modern async await.

See conversation here for more context: #66 (review)

You're right, we are not handling async well at all in this code - we would benefit greatly from a quick port to async/await syntax and ditching coroutines.

Definition of Done

Upgrade this library from bluebird coroutines to async await. All test should pass.

See note here: #66 (comment) for details on that.
@cooncesean cooncesean added 3 code-challenge This issue has been groomed and is ready to be picked up by a code challenge participant. labels Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 code-challenge This issue has been groomed and is ready to be picked up by a code challenge participant.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cooncesean