From 55caa4a6ddcb7699732d6259f1a2db014008a815 Mon Sep 17 00:00:00 2001 From: Otto Allmendinger Date: Fri, 13 Dec 2024 12:34:39 +0100 Subject: [PATCH] fix(abstract-utxo): pass actual wallet to signTransaction Issue: BTC-1450 --- modules/sdk-coin-hbar/src/hbar.ts | 1 - modules/sdk-coin-trx/src/trx.ts | 1 - modules/sdk-coin-xtz/src/xtz.ts | 1 - modules/sdk-core/src/bitgo/wallet/wallet.ts | 5 +---- 4 files changed, 1 insertion(+), 7 deletions(-) diff --git a/modules/sdk-coin-hbar/src/hbar.ts b/modules/sdk-coin-hbar/src/hbar.ts index 622edafd66..b035118c10 100644 --- a/modules/sdk-coin-hbar/src/hbar.ts +++ b/modules/sdk-coin-hbar/src/hbar.ts @@ -273,7 +273,6 @@ export class Hbar extends BaseCoin { * @param params * @param params.txPrebuild {Object} prebuild object returned by platform * @param params.prv {String} user prv - * @param params.wallet.addressVersion {String} this is the version of the Algorand multisig address generation format * @returns Promise */ async signTransaction(params: HbarSignTransactionOptions): Promise { diff --git a/modules/sdk-coin-trx/src/trx.ts b/modules/sdk-coin-trx/src/trx.ts index d0330450f8..bad2a679da 100644 --- a/modules/sdk-coin-trx/src/trx.ts +++ b/modules/sdk-coin-trx/src/trx.ts @@ -263,7 +263,6 @@ export class Trx extends BaseCoin { * @param params * @param params.txPrebuild {Object} prebuild object returned by platform * @param params.prv {String} user prv - * @param params.wallet.addressVersion {String} this is the version of the Algorand multisig address generation format * @returns Bluebird */ async signTransaction(params: TronSignTransactionOptions): Promise { diff --git a/modules/sdk-coin-xtz/src/xtz.ts b/modules/sdk-coin-xtz/src/xtz.ts index 1581854d3e..3159db1ba2 100644 --- a/modules/sdk-coin-xtz/src/xtz.ts +++ b/modules/sdk-coin-xtz/src/xtz.ts @@ -131,7 +131,6 @@ export class Xtz extends BaseCoin { * @param params * @param params.txPrebuild {Object} prebuild object returned by platform * @param params.prv {String} user prv - * @param params.wallet.addressVersion {String} this is the version of the Algorand multisig address generation format * @returns Bluebird */ async signTransaction(params: Interface.XtzSignTransactionOptions): Promise { diff --git a/modules/sdk-core/src/bitgo/wallet/wallet.ts b/modules/sdk-core/src/bitgo/wallet/wallet.ts index 01af167c64..65eb8498fa 100644 --- a/modules/sdk-core/src/bitgo/wallet/wallet.ts +++ b/modules/sdk-core/src/bitgo/wallet/wallet.ts @@ -2147,10 +2147,7 @@ export class Wallet implements IWallet { const signingParams = { ...params, txPrebuild, - wallet: { - // this is the version of the multisig address at wallet creation time - addressVersion: this._wallet.coinSpecific.addressVersion, - }, + wallet: this, keychain: keychains[0], backupKeychain: keychains.length > 1 ? keychains[1] : null, bitgoKeychain: keychains.length > 2 ? keychains[2] : null,