Added Configuration Tests and Configured Jacoco #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanHalacogluImproving
force-pushed
the
java/dev_SanH_configuration_tests
branch
from
3761294 to
71556d3
Compare
acarbonetto
reviewed
Jan 11, 2024
acarbonetto
force-pushed
the
java/integ_acarbo_refactor_api_submitRequests
branch
from
cb1966e to
cada9b7
Compare
Comment on lines
89
to
90
| public static List createSetOptions(SetOptions options) { | ||
| List optionArgs = new LinkedList(); |
There was a problem hiding this comment.
Suggested change
| public static List createSetOptions(SetOptions options) { | |
| List optionArgs = new LinkedList(); | |
| public static List<String> createSetOptions(SetOptions options) { | |
| List<String> optionArgs = new LinkedList<>(); |
| } else { | ||
| if (options.expiry.count == null) { | ||
| throw new RequestException( | ||
| "Set command received expiry type " + options.expiry.type + "but count was not set."); |
There was a problem hiding this comment.
Suggested change
| "Set command received expiry type " + options.expiry.type + "but count was not set."); | |
| "Set command received expiry type " + options.expiry.type + ", but count was not set."); |
java/client/src/main/java/glide/api/models/commands/SetOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/configuration/BackoffStrategy.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Andrew Carbonetto <[email protected]>
* Add base command; add custom command --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
…entloopGroup and channel configuration for Netty.
Removed wildcard imports. Fixed wording in documentation.
Signed-off-by: Andrew Carbonetto <[email protected]>
Applied Spotless. Removed RequestBuilder.
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
java/dev_SanH_configuration_tests
branch
from
71556d3 to
b9c9ee4
Compare
acarbonetto
changed the base branch from
java/integ_acarbo_refactor_api_submitRequests
to
java/dev_SanH_ThreadPoolResourceAllocator
Signed-off-by: Andrew Carbonetto <[email protected]>
…v_SanH_configuration_tests
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
| @@ -0,0 +1 @@ | |||
| lombok.addLombokGeneratedAnnotation = true | |||
Comment on lines
+71
to
+77
| assertEquals(new ArrayList<NodeAddress>(), redisClientConfiguration.getAddresses()); | ||
| assertFalse(redisClientConfiguration.isUseTLS()); | ||
| assertEquals(ReadFrom.PRIMARY, redisClientConfiguration.getReadFrom()); | ||
| assertNull(redisClientConfiguration.getCredentials()); | ||
| assertNull(redisClientConfiguration.getRequestTimeout()); | ||
| assertNull(redisClientConfiguration.getDatabaseId()); | ||
| assertNull(redisClientConfiguration.getReconnectStrategy()); |
| () -> assertEquals(expectedNodeAddress.getPort(), actualNodeAddress.getPort())); | ||
| } | ||
| assertTrue(redisClientConfiguration.isUseTLS()); | ||
| assertEquals(ReadFrom.PREFER_REPLICA, redisClientConfiguration.getReadFrom()); |
Comment on lines
+130
to
+133
| assertEquals(connectionManager, client.connectionManager); | ||
| assertEquals(commandManager, client.commandManager); | ||
| } catch (Exception cancellationException) { | ||
| assertTrue(cancellationException instanceof CancellationException); |
There was a problem hiding this comment.
Only one branch should succceed. If you test cancellation, add fail() into try block
Comment on lines
+161
to
+164
| assertEquals(connectionManager, client.connectionManager); | ||
| assertEquals(commandManager, client.commandManager); | ||
| } catch (Exception exception) { | ||
| assertEquals(interruptedException, exception.getCause()); |
|
|
||
| @Test | ||
| public void getOrCreateReturnsDefault() { | ||
| (new ThreadPoolResourceAllocator.ShutdownHook()).run(); | ||
| (new DefaultThreadPoolResourceHandler.ShutdownHook()).run(); |
There was a problem hiding this comment.
Suggested change
| (new DefaultThreadPoolResourceHandler.ShutdownHook()).run(); | |
| new DefaultThreadPoolResourceHandler.ShutdownHook().run(); |
| @@ -38,6 +39,6 @@ public void getOrCreateReturnsDefault() { | |||
| // remove the mocked resource | |||
| EventLoopGroup mockedELG = mock(EventLoopGroup.class); | |||
| when(mockedThreadPool.getEventLoopGroup()).thenReturn(mockedELG); | |||
| (new ThreadPoolResourceAllocator.ShutdownHook()).run(); | |||
| (new DefaultThreadPoolResourceHandler.ShutdownHook()).run(); | |||
There was a problem hiding this comment.
Suggested change
| (new DefaultThreadPoolResourceHandler.ShutdownHook()).run(); | |
| new DefaultThreadPoolResourceHandler.ShutdownHook().run(); |
SanHalacogluImproving
force-pushed
the
java/dev_SanH_ThreadPoolResourceAllocator
branch
3 times, most recently
from
5cc435d to
26fc46d
Compare
SanHalacogluImproving
deleted the branch
java/dev_SanH_ThreadPoolResourceAllocator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Configuration Tests and added jacoco.
Applied Spotless.
Removed RequestBuilder.