Java: new README.md #395
Merged
Java: new README.md #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyip10
commented
Jun 27, 2024
yipin-chen
approved these changes
Jun 27, 2024
Elen-Ghulam
approved these changes
Jun 27, 2024
Closed
cyip10
force-pushed
the
java/dev_cyip10_readmeNew
branch
from
4a3924c to
54a16ea
Compare
GumpacG
approved these changes
Jun 28, 2024
GumpacG
reviewed
Jun 28, 2024
jduo
reviewed
Jun 28, 2024
jduo
reviewed
Jun 28, 2024
jduo
reviewed
Jun 28, 2024
jduo
reviewed
Jun 28, 2024
jduo
reviewed
Jun 28, 2024
| ### Build from source | ||
|
|
||
| Software Dependencies: | ||
| #### Prerequisites |
There was a problem hiding this comment.
We should mention that an existing Valkey-compatible server is required to run the integration tests. Probably shouldn't say "install redis".
There was a problem hiding this comment.
I believe IT expects redis-server to be installed.
https://github.com/aws/glide-for-redis/blob/main/utils/cluster_manager.py#L287
There was a problem hiding this comment.
Wait, should we leave redis references in the code?
There was a problem hiding this comment.
until there's an equivalent setup for valkey-server, we don't have a choice.
There was a problem hiding this comment.
same change needed here: https://github.com/Bit-Quill/glide-for-redis/blob/main/python/DEVELOPER.md?plain=1#L113
cyip10
commented
Jun 28, 2024
acarbonetto
approved these changes
Jun 28, 2024
alexey-temnikov
requested changes
Jun 29, 2024
tetrachromium
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an issue with git. Had to duplicate the PR to this one. Will close the old one.
#388