forked from aws/amazon-neptune-for-graphql
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Unit Test Case01.04 #9
Open
sophiadt
wants to merge
11
commits into
main
Choose a base branch
from
testFix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all tests pass except 01.04 but at least it runs
all tests passed except 7 and 12
andreachild
reviewed
Nov 28, 2024
andreachild
reviewed
Nov 28, 2024
andreachild
reviewed
Nov 28, 2024
andreachild
reviewed
Nov 28, 2024
andreachild
reviewed
Dec 6, 2024
andreachild
reviewed
Dec 10, 2024
andreachild
reviewed
Dec 10, 2024
@@ -8,6 +8,7 @@ | |||
}, | |||
"author": "", | |||
"license": "ISC", | |||
"type": "module", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kris mentioned that you should be able to revert the renaming of js
files to mjs
can be potentially be reverted after this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Unit Test Case01.04
test Case0.104 gave
Uncaught ReferenceError: require is not defined
This is because
require
is a Node.js function but the package type is defined asmodule
inpackage.json
, so we have to use ES modules likeimport
andexport
. But then Jest wouldn't be able to parse the file soJSResolverOCHTTPSTemplate
,output.resolver.graphql.cjs
,testLib
were changed to.mjs
files to mark those files as ES modules.Changes:
JSResolverOCHTTPSTemplate
,output.resolver.graphql.cjs
,testLib
to.mjs
export default { resolveGraphDBQueryFromAppSyncEvent, resolveGraphDBQueryFromApolloQueryEvent }
so it works with the pkg import"type": "module",
in the package.json files forLambda4AppSyncHTTP
andLambda4AppSyncSDK
in the templates folder