Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request: fix discarded_futures linter issues #138

Open
1 task done
mgenware opened this issue Nov 16, 2024 · 0 comments
Open
1 task done

request: fix discarded_futures linter issues #138

mgenware opened this issue Nov 16, 2024 · 0 comments

Comments

@mgenware
Copy link

mgenware commented Nov 16, 2024 •
edited
Loading

Is there an existing feature request for this?

  • I have searched the existing issues.

Command

Update goldenTest so that discarded_futures is gone

Description

image Linter keeps complaining `discarded_futures` issue. I think `discarded_futures` is a very important rule and should not be added to project-wide ignored rules.

Reasoning

If goldenTest is not to be awaited, maybe we can return void?

Additional context and comments

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgenware